Conversation
- fully self-contained project as subfolder - uses release version of cql-execution
Ideally we would use the code from src directly, but typescript isn't happy
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #360 +/- ##
=======================================
Coverage 87.58% 87.58%
=======================================
Files 52 52
Lines 4607 4607
Branches 1297 1297
=======================================
Hits 4035 4035
Misses 359 359
Partials 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a test server that exposes a
$cqltarget to allow the CQL Tests Runner to run tests against thecql-executionengine. Rather than repeat all the details here, I'll refer you to the test-server/README.md file in this branch.I initially developed this as a standalone project outside of
cql-executionthat pulled incql-executionas an NPM dependency. This PR integrates it into thecql-executionproject as a sub-project with its ownpackage.jsonand configuration files. In addition to general review of the code, I'm also interested in thoughts on this approach. Should we:cql-executionbut try to integrate it more closely (i.e., sharepackage.jsonand configuration files)?cql-execution(and if so, where)?I have not yet invested in updating GitHub actions to automatically run the tests or other checks in the sub-project. I will do that after we have confirmed the approach.
NOTE: The npm audit check is currently failing due to a reported vulnerability in elliptic. There is currently no fix for that.
Submitter:
npm run test:plusto run tests, lint, and prettier)cql4browsers.jsbuilt withnpm run build:browserifyif source changed.Reviewer:
Name: